Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 executableFolderPath to run app name in iOS 14.0 #1236

Merged
merged 1 commit into from
Aug 18, 2020
Merged

fix: 🐛 executableFolderPath to run app name in iOS 14.0 #1236

merged 1 commit into from
Aug 18, 2020

Conversation

oeduardoal
Copy link
Contributor

@oeduardoal oeduardoal commented Aug 2, 2020 •
edited
Loading

Summary:

Fix: #1208

This behavior
image

with this envs:

PRODUCT_BUNDLE_IDENTIFIER = paz.church;
PRODUCT_NAME = Paz.Church;

Test Plan:

 react-native run-ios --simulator="iPhone 11 Pro Max"
error React Native CLI uses autolinking for native dependencies, but the following modules are linked manually:
  - react-native-code-push (to unlink run: "react-native unlink react-native-code-push")
This is likely happening when upgrading React Native from below 0.60 to 0.60 or above. Going forward, you can unlink this dependency via "react-native unlink <dependency>" and it will be included in your app automatically. If a library isn't compatible with autolinking, disregard this message and notify the library maintainers.
Read more about autolinking: https://github.com/react-native-community/cli/blob/master/docs/autolinking.md
info Found Xcode workspace "pazchurch.xcworkspace"
info Building (using "xcodebuild -workspace pazchurch.xcworkspace -configuration Debug -scheme pazchurch -destination id=8A35A779-3306-4EEA-A4C5-EEAF9303C236")
..........................................
wrapperExtension app
info Installing "/Users/emmet/Library/Developer/Xcode/DerivedData/pazchurch-dfffuyvjrmhokibjznhcqhpichmy/Build/Products/Debug-iphonesimulator/Paz.Church.app"
info Launching "paz.church"
success Successfully launched the app on the simulator

@oeduardoal
Copy link
Contributor Author

@SConaway

@SConaway
Copy link
Contributor

SConaway commented Aug 2, 2020

Just tested it and it seems to have solved this issue. I am quite familiar with JS / TS, but I missed the CONTRIBUTING.md so I was unsure how I'd link the packages from this repo to my own projects. Thanks!

SConaway
SConaway approved these changes Aug 2, 2020
View reviewed changes
Copy link
Contributor

@SConaway SConaway left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (I know I'm not a requested reviewer)

@oeduardoal
Copy link
Contributor Author

#1235

@oeduardoal oeduardoal mentioned this pull request Aug 8, 2020
Closed
@Swor71
Copy link
Contributor

Swor71 commented Aug 18, 2020

@oeduardoal I went over this pr today and it looks good to me. Already mentioned that to @thymikee.

@thymikee thymikee requested a review from alloy August 18, 2020 11:51
alloy
alloy approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@alloy alloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me 👍

@thymikee thymikee merged commit c736b21 into react-native-community:master Aug 18, 2020
@oeduardoal oeduardoal deleted the fix/executable-path-dir branch August 18, 2020 17:23
@oeduardoal oeduardoal restored the fix/executable-path-dir branch August 18, 2020 17:23
thymikee added a commit that referenced this pull request Sep 17, 2020
@thymikee
Merge remote-tracking branch 'origin/master' into pr/1072
6004005 
* origin/master: (81 commits)
  chore(deps): bump node-fetch from 2.6.0 to 2.6.1 (#1267)
  v4.13.0
  chore: remove await in getLatestFile function call from downloadProfile file. (#1266)
  Augment react-native info with out of tree platform packages info (#1264)
  feat: add a command to download the Hermes Sampling Profiler to a local machine (#1246)
  chore(deps): bump lodash from 4.17.15 to 4.17.19 (#1221)
  Fix package name for main activity when appId set (#1242)
  Just use the users default browser (#1257)
  feat: improve progress indicator for iOS builds without xcpretty (#1254)
  fix: 🐛 executableFolderPath to run app name in iOS 14.0 (#1236)
  chore(deps): bump elliptic from 6.5.2 to 6.5.3 (#1233)
  v4.12.0
  Add Windows info to react-native info (#1227)
  add new version RN Podfile link, autolinking docs. (#1245)
  docs: add linkage instructions for `yarn` v2 (#1237)
  v4.11.0
  fix: adjust range on react-native peer dep to support 0.63 (#1234)
  chore: update jest config (#1241)
  Use new chrome based edge if the user is already running it, and not running chrome (#1222)
  Add windows logic to guess the users preferred editor for launchEditor (#1216)
  ...
thymikee added a commit to imoans/cli that referenced this pull request Sep 17, 2020
@thymikee
Merge remote-tracking branch 'origin/master' into pr/1146
885157c 
* origin/master: (47 commits)
  chore(breaking): use Node 10 as compile target (react-native-community#1072)
  chore(deps): bump node-fetch from 2.6.0 to 2.6.1 (react-native-community#1267)
  v4.13.0
  chore: remove await in getLatestFile function call from downloadProfile file. (react-native-community#1266)
  Augment react-native info with out of tree platform packages info (react-native-community#1264)
  feat: add a command to download the Hermes Sampling Profiler to a local machine (react-native-community#1246)
  chore(deps): bump lodash from 4.17.15 to 4.17.19 (react-native-community#1221)
  Fix package name for main activity when appId set (react-native-community#1242)
  Just use the users default browser (react-native-community#1257)
  feat: improve progress indicator for iOS builds without xcpretty (react-native-community#1254)
  fix: 🐛 executableFolderPath to run app name in iOS 14.0 (react-native-community#1236)
  chore(deps): bump elliptic from 6.5.2 to 6.5.3 (react-native-community#1233)
  v4.12.0
  Add Windows info to react-native info (react-native-community#1227)
  add new version RN Podfile link, autolinking docs. (react-native-community#1245)
  docs: add linkage instructions for `yarn` v2 (react-native-community#1237)
  v4.11.0
  fix: adjust range on react-native peer dep to support 0.63 (react-native-community#1234)
  chore: update jest config (react-native-community#1241)
  Use new chrome based edge if the user is already running it, and not running chrome (react-native-community#1222)
  ...
@oeduardoal oeduardoal mentioned this pull request Sep 21, 2020
Closed
@ljcp ljcp mentioned this pull request Oct 15, 2020
Merged
10 tasks
ghills pushed a commit to ghills/cli that referenced this pull request Nov 6, 2020
@oeduardoal
fix: 🐛 executableFolderPath to run app name in iOS 14.0 (react-native…
b2858c5 
…-community#1236)

(cherry picked from commit c736b21)
Signed-off-by: Gavin Hills <gavin.hills@agencyrm.com>
@ghills ghills mentioned this pull request Nov 6, 2020
Merged
thymikee pushed a commit that referenced this pull request Nov 18, 2020
@ghills @oeduardoal
fix: 🐛 executableFolderPath to run app name in iOS 14.0 (#1236) (#1308)
18be139 
(cherry picked from commit c736b21)
Signed-off-by: Gavin Hills <gavin.hills@agencyrm.com>

Co-authored-by: Eduardo Almeida <oeduardoal@gmail.com>
jeanregisser added a commit to celo-org/celo-monorepo that referenced this pull request Nov 18, 2020
@jeanregisser
Upgrade react-native cli to fix yarn dev:ios unable to launch app o…
9a699af 
…n the simulator with iOS 14

See react-native-community/cli#1236
@jeanregisser jeanregisser mentioned this pull request Nov 18, 2020
Merged
mergify bot pushed a commit to celo-org/celo-monorepo that referenced this pull request Nov 19, 2020
@jeanregisser
[Wallet] Fix yarn dev:ios unable to install app with iOS 14 (#5911)
736cabb 
### Description

Upgrade react-native cli to fix `yarn dev:ios` unable to launch app on the simulator with iOS 14

See react-native-community/cli#1236

### Other changes

Use Xcode 12.2.0 image on CircleCI

### Tested



**before**

```
❯ yarn dev:ios
[...]
info Installing "/Users/jean/Library/Developer/Xcode/DerivedData/celo-afcaqctmxgqdxzfelzubxksctyfx/Build/Products/Debug-iphonesimulator/celo-alfajoresdev.app"
An error was encountered processing the command (domain=NSPOSIXErrorDomain, code=2):
Failed to install the requested application
An application bundle was not found at the provided path.
Provide a valid path to the desired application bundle.
Print: Entry, ":CFBundleIdentifier", Does Not Exist
error Command failed: /usr/libexec/PlistBuddy -c Print:CFBundleIdentifier /Users/jean/Library/Developer/Xcode/DerivedData/celo-afcaqctmxgqdxzfelzubxksctyfx/Build/Products/Debug-iphonesimulator/celo-alfajoresdev.app/Info.plist
Print: Entry, ":CFBundleIdentifier", Does Not Exist
```


**after**
```
❯ yarn dev:ios
[...]
info Installing "/Users/jean/Library/Developer/Xcode/DerivedData/celo-afcaqctmxgqdxzfelzubxksctyfx/Build/Products/Debug-iphonesimulator/celo.app"
info Launching "org.celo.mobile.alfajores.dev"
success Successfully launched the app on the simulator
```

### Related issues

None

### Backwards compatibility

Yes.
@tido64 tido64 mentioned this pull request Dec 4, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swor71 Swor71 Swor71 approved these changes

@SConaway SConaway SConaway approved these changes

@alloy alloy alloy approved these changes

@Esemesek Esemesek Awaiting requested review from Esemesek

@grabbou grabbou Awaiting requested review from grabbou

@thymikee thymikee Awaiting requested review from thymikee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build fails to install when using the iOS 14 SDK
5 participants
@oeduardoal @SConaway @Swor71 @alloy @thymikee